netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Flavio Leitner <fbl@redhat.com>
To: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org, dlstevens@us.ibm.com
Subject: Re: [PATCH net-next 1/2] ipv6: introduce per-interface counter for dad-completed ipv6 addresses
Date: Thu, 27 Jun 2013 19:02:36 -0300	[thread overview]
Message-ID: <20130627220236.GA25037@obelix.rh> (raw)
In-Reply-To: <20130626220656.GA20845@order.stressinduktion.org>

On Thu, Jun 27, 2013 at 12:06:56AM +0200, Hannes Frederic Sowa wrote:
> To reduce the number of unnecessary router solicitations, MLDv2 and IGMPv3
> messages we need to track the number of valid (as in non-optimistic,
> no-dad-failed and non-tentative) link-local addresses. Therefore, this
> patch implements a valid_ll_addr_cnt in struct inet6_dev.
> 
> We now only emit router solicitations if the first link-local address
> finishes duplicate address detection.
> 
> The changes for MLDv2 and IGMPv3 are in a follow-up patch.
> 
> While there, also simplify one if statement(one minor nit I made in one
> of my previous patches):
> 
> if (!...)
> 	do();
> else
> 	return;
> 
> <<into>>
> 
> if (...)
> 	return;
> do();
> 
> Cc: Flavio Leitner <fbl@redhat.com>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Cc: David Stevens <dlstevens@us.ibm.com>
> Suggested-by: David Stevens <dlstevens@us.ibm.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---

Looks good and works here.
thanks,
Acked-by: Flavio Leitner <fbl@redhat.com>

  reply	other threads:[~2013-06-27 22:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26 22:06 [PATCH net-next 1/2] ipv6: introduce per-interface counter for dad-completed ipv6 addresses Hannes Frederic Sowa
2013-06-27 22:02 ` Flavio Leitner [this message]
2013-06-29  4:19   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130627220236.GA25037@obelix.rh \
    --to=fbl@redhat.com \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).