From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH] Set the correct RTNL family for multicast netconf messages Date: Fri, 28 Jun 2013 03:51:21 +0200 Message-ID: <20130628015121.GC15799@order.stressinduktion.org> References: <1372376687.21767.10.camel@imac-linux.luckyscavenger.com> <20130628012307.GB15799@order.stressinduktion.org> <20130627183342.4b9c5598@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Sven-Thorsten Dietrich , LKML , Stephen Hemminger , "nicolas.dichtel@6wind.com" , "netdev@vger.kernel.org" , Mike Davison To: Stephen Hemminger Return-path: Content-Disposition: inline In-Reply-To: <20130627183342.4b9c5598@nehalam.linuxnetplumber.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Jun 27, 2013 at 06:33:42PM -0700, Stephen Hemminger wrote: > On Fri, 28 Jun 2013 03:23:07 +0200 > Hannes Frederic Sowa wrote: > > Hm, are you sure? NETCONFA_MC_FORWARDING is of type RTM_NEWNETCONF > > and expects ncm_family to be either AF_INET or AF_INET6 (at least in > > iproute2/ipmonitor.c). > > > > I agree with Sven on this, looks like the recent addition of netconf > configuration to netlink didn't embrace how multicast is handled in kernel. > > Multicast forwarding is a routing related configuration value. > All the multicast routing events come in as special family RTNL_FAMILY_IPMR > (see net/ipv4/ipmr.c function ipmr_fill_route). I would expect that multicast > routing daemons would like to be able to use special family to listen for > all multicast related changes (and not see non-multicast events). > > > Minor nit: the patch is formatted incorrectly (case should line up with switch). Yes, this seems reasonable but would need a small update to ipnetconf.c, too. Thanks, Hannes