From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: joe.jin@oracle.com, frank.blaschka@de.ibm.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
zheng.x.li@oracle.com, xen-devel@lists.xen.org,
Ian.Campbell@citrix.com, JBeulich@suse.com,
stefano.stabellini@eu.citrix.com
Subject: Re: kernel panic in skb_copy_bits
Date: Mon, 01 Jul 2013 13:36:15 -0700 (PDT) [thread overview]
Message-ID: <20130701.133615.366371022223254228.davem@davemloft.net> (raw)
In-Reply-To: <1372412262.3301.251.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 28 Jun 2013 02:37:42 -0700
> [PATCH] neighbour: fix a race in neigh_destroy()
>
> There is a race in neighbour code, because neigh_destroy() uses
> skb_queue_purge(&neigh->arp_queue) without holding neighbour lock,
> while other parts of the code assume neighbour rwlock is what
> protects arp_queue
>
> Convert all skb_queue_purge() calls to the __skb_queue_purge() variant
>
> Use __skb_queue_head_init() instead of skb_queue_head_init()
> to make clear we do not use arp_queue.lock
>
> And hold neigh->lock in neigh_destroy() to close the race.
>
> Reported-by: Joe Jin <joe.jin@oracle.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
next prev parent reply other threads:[~2013-07-01 20:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 2:58 kernel panic in skb_copy_bits Joe Jin
2013-06-27 5:31 ` Eric Dumazet
2013-06-27 7:15 ` Joe Jin
2013-06-28 4:17 ` Joe Jin
2013-06-28 6:52 ` Eric Dumazet
2013-06-28 9:37 ` Eric Dumazet
2013-06-28 11:33 ` Joe Jin
2013-06-28 23:36 ` Joe Jin
2013-06-29 7:04 ` Eric Dumazet
2013-06-29 7:20 ` Eric Dumazet
2013-06-29 16:11 ` Ben Greear
2013-06-29 16:26 ` Eric Dumazet
2013-06-29 16:31 ` Ben Greear
2013-06-30 0:26 ` Joe Jin
2013-06-30 7:50 ` Eric Dumazet
2013-07-01 20:36 ` David Miller [this message]
2013-06-30 9:13 ` Alex Bligh
2013-06-30 9:35 ` Alex Bligh
2013-07-01 3:18 ` Joe Jin
2013-07-01 8:11 ` Ian Campbell
2013-07-01 13:00 ` Joe Jin
2013-07-04 8:55 ` Joe Jin
2013-07-04 8:59 ` Ian Campbell
2013-07-04 9:34 ` Eric Dumazet
2013-07-04 9:52 ` Ian Campbell
2013-07-04 10:12 ` Eric Dumazet
2013-07-04 12:57 ` Alex Bligh
2013-07-04 21:32 ` David Miller
2013-07-01 8:29 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701.133615.366371022223254228.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=eric.dumazet@gmail.com \
--cc=frank.blaschka@de.ibm.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zheng.x.li@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).