From: David Miller <davem@davemloft.net>
To: davej@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: fix broken locking in x25 ioctl error paths
Date: Mon, 01 Jul 2013 18:16:38 -0700 (PDT) [thread overview]
Message-ID: <20130701.181638.1716586890151526311.davem@davemloft.net> (raw)
In-Reply-To: <20130628161352.GA16505@redhat.com>
From: Dave Jones <davej@redhat.com>
Date: Fri, 28 Jun 2013 12:13:52 -0400
> Two of the x25 ioctl cases have error paths that break out of the function without
> unlocking the socket, leading to this warning:
>
> ================================================
> [ BUG: lock held when returning to user space! ]
> 3.10.0-rc7+ #36 Not tainted
> ------------------------------------------------
> trinity-child2/31407 is leaving the kernel with locks still held!
> 1 lock held by trinity-child2/31407:
> #0: (sk_lock-AF_X25){+.+.+.}, at: [<ffffffffa024b6da>] x25_ioctl+0x8a/0x740 [x25]
>
> Signed-off-by: Dave Jones <davej@redhat.com>
Applied and queued up for -stable, thanks Dave.
In the future please prefix your patch subject lines with "$subsystem: ", for
this I rewrote it as:
x25: Fix broken locking in ioctl error paths.
Thanks!
prev parent reply other threads:[~2013-07-02 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 15:14 fix broken locking in x25 ioctl error paths Dave Jones
2013-06-28 15:19 ` Eric Dumazet
2013-06-28 15:36 ` Dave Jones
2013-06-28 16:13 ` Dave Jones
2013-07-02 1:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701.181638.1716586890151526311.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).