From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: netdev@vger.kernel.org, pshelar@nicira.com
Subject: Re: [Patch net-next v3] gre: fix a regression in ioctl
Date: Mon, 01 Jul 2013 23:36:01 -0700 (PDT) [thread overview]
Message-ID: <20130701.233601.1074563806368770464.davem@davemloft.net> (raw)
In-Reply-To: <1372478579-6548-1-git-send-email-amwang@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Sat, 29 Jun 2013 12:02:59 +0800
> From: Cong Wang <amwang@redhat.com>
>
> When testing GRE tunnel, I got:
>
> # ip tunnel show
> get tunnel gre0 failed: Invalid argument
> get tunnel gre1 failed: Invalid argument
>
> This is a regression introduced by commit c54419321455631079c7d
> ("GRE: Refactor GRE tunneling code.") because previously we
> only check the parameters for SIOCADDTUNNEL and SIOCCHGTUNNEL,
> after that commit, the check is moved for all commands.
>
> So, just check for SIOCADDTUNNEL and SIOCCHGTUNNEL.
>
> After this patch I got:
>
> # ip tunnel show
> gre0: gre/ip remote any local any ttl inherit nopmtudisc
> gre1: gre/ip remote 192.168.122.101 local 192.168.122.45 ttl inherit
>
> Cc: Pravin B Shelar <pshelar@nicira.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2013-07-02 6:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 2:04 [Patch net-next] gre: fix a regression in ioctl Cong Wang
2013-06-29 2:16 ` Cong Wang
2013-06-29 2:24 ` [Patch net-next v2] " Cong Wang
2013-06-29 3:28 ` Pravin Shelar
2013-06-29 3:33 ` Cong Wang
2013-06-29 3:55 ` Cong Wang
2013-06-29 4:02 ` [Patch net-next v3] " Cong Wang
2013-06-29 18:42 ` Dmitry Kravkov
2013-07-01 2:06 ` Cong Wang
2013-07-02 6:36 ` David Miller [this message]
2013-06-29 15:52 ` [Patch net-next v2] " Sergei Shtylyov
2013-07-01 2:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701.233601.1074563806368770464.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).