From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: amwang@redhat.com, netdev@vger.kernel.org,
dingtianhong@huawei.com, yoshfuji@linux-ipv6.org
Subject: Re: [Patch net-next v2] ipv6,mcast: always hold idev->lock before mca_lock
Date: Mon, 01 Jul 2013 23:39:52 -0700 (PDT) [thread overview]
Message-ID: <20130701.233952.1511019763676664574.davem@davemloft.net> (raw)
In-Reply-To: <20130629144052.GB6519@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 29 Jun 2013 16:40:52 +0200
> On Sat, Jun 29, 2013 at 10:09:41PM +0800, Cong Wang wrote:
>> On Sat, 2013-06-29 at 15:53 +0200, Hannes Frederic Sowa wrote:
>> >
>> > If we export __ipv6_get_lladdr in a header, shouldn't we also EXPORT_SYMBOL
>> > it? I am not sure but would have done so.
>>
>> Why? It is used only by IPv6 module itself.
>
> Yes, you are right. We don't export ipv6_get_lladdr either, so:
>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied, thanks!
prev parent reply other threads:[~2013-07-02 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 13:30 [Patch net-next v2] ipv6,mcast: always hold idev->lock before mca_lock Cong Wang
2013-06-29 13:53 ` Hannes Frederic Sowa
2013-06-29 14:09 ` Cong Wang
2013-06-29 14:40 ` Hannes Frederic Sowa
2013-07-02 6:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701.233952.1511019763676664574.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=dingtianhong@huawei.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).