From: David Miller <davem@davemloft.net>
To: pshelar@nicira.com
Cc: netdev@vger.kernel.org, timo.teras@iki.fi
Subject: Re: [PATCH net v2] ip_tunnels: Use skb-len to PMTU check.
Date: Mon, 01 Jul 2013 23:56:54 -0700 (PDT) [thread overview]
Message-ID: <20130701.235654.449447235538486676.davem@davemloft.net> (raw)
In-Reply-To: <1372660232-12174-1-git-send-email-pshelar@nicira.com>
From: Pravin B Shelar <pshelar@nicira.com>
Date: Sun, 30 Jun 2013 23:30:32 -0700
> In path mtu check, ip header total length works for gre device
> but not for gre-tap device. Use skb len which is consistent
> for all tunneling types. This is old bug in gre.
> This also fixes mtu calculation bug introduced by
> commit c54419321455631079c7d (GRE: Refactor GRE tunneling code).
>
> Reported-by: Timo Teras <timo.teras@iki.fi>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Can you please respin this against net-next? The packet building
flow is significantly different there.
I'll keep this copy around for -stable.
Thanks!
prev parent reply other threads:[~2013-07-02 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 6:30 [PATCH net v2] ip_tunnels: Use skb-len to PMTU check Pravin B Shelar
2013-07-01 6:41 ` Timo Teras
2013-07-01 7:06 ` Pravin Shelar
2013-07-01 12:18 ` Timo Teras
2013-07-02 6:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130701.235654.449447235538486676.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).