From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net v2] ip_tunnels: Use skb-len to PMTU check. Date: Mon, 01 Jul 2013 23:56:54 -0700 (PDT) Message-ID: <20130701.235654.449447235538486676.davem@davemloft.net> References: <1372660232-12174-1-git-send-email-pshelar@nicira.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, timo.teras@iki.fi To: pshelar@nicira.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:47735 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887Ab3GBG4z (ORCPT ); Tue, 2 Jul 2013 02:56:55 -0400 In-Reply-To: <1372660232-12174-1-git-send-email-pshelar@nicira.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Pravin B Shelar Date: Sun, 30 Jun 2013 23:30:32 -0700 > In path mtu check, ip header total length works for gre device > but not for gre-tap device. Use skb len which is consistent > for all tunneling types. This is old bug in gre. > This also fixes mtu calculation bug introduced by > commit c54419321455631079c7d (GRE: Refactor GRE tunneling code). > > Reported-by: Timo Teras > Signed-off-by: Pravin B Shelar Can you please respin this against net-next? The packet building flow is significantly different there. I'll keep this copy around for -stable. Thanks!