* [PATCH net-next] bnx2x: fill in sane dump flag information
@ 2013-07-01 15:23 Michal Schmidt
2013-07-02 7:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michal Schmidt @ 2013-07-01 15:23 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Miriam Shitrit, Yuval Mintz, Ariel Elior
bnx2x did not set dump->version in its .get_dump_flag() method.
Let's set it to BNX2X_DUMP_VERSION. It's not a particularly nice
number (0x50acff01 currently), but at least it's something
deterministic.
dump->flag should report the value previously set using ethtool -W.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index 10b52b0..8f96442 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -972,12 +972,12 @@ static int bnx2x_get_dump_flag(struct net_device *dev,
{
struct bnx2x *bp = netdev_priv(dev);
+ dump->version = BNX2X_DUMP_VERSION;
+ dump->flag = bp->dump_preset_idx;
/* Calculate the requested preset idx length */
dump->len = bnx2x_get_preset_regs_len(dev, bp->dump_preset_idx);
DP(BNX2X_MSG_ETHTOOL, "Get dump preset %d length=%d\n",
bp->dump_preset_idx, dump->len);
-
- dump->flag = ETHTOOL_GET_DUMP_DATA;
return 0;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] bnx2x: fill in sane dump flag information
2013-07-01 15:23 [PATCH net-next] bnx2x: fill in sane dump flag information Michal Schmidt
@ 2013-07-02 7:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-07-02 7:16 UTC (permalink / raw)
To: mschmidt; +Cc: netdev, miris, yuvalmin, ariele
From: Michal Schmidt <mschmidt@redhat.com>
Date: Mon, 1 Jul 2013 17:23:20 +0200
> bnx2x did not set dump->version in its .get_dump_flag() method.
> Let's set it to BNX2X_DUMP_VERSION. It's not a particularly nice
> number (0x50acff01 currently), but at least it's something
> deterministic.
>
> dump->flag should report the value previously set using ethtool -W.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-02 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-01 15:23 [PATCH net-next] bnx2x: fill in sane dump flag information Michal Schmidt
2013-07-02 7:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).