netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch -next] net/mlx4: fix small memory leak on error
@ 2013-07-03  9:37 Dan Carpenter
  2013-07-03 23:52 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-07-03  9:37 UTC (permalink / raw)
  To: David S. Miller
  Cc: Or Gerlitz, Roland Dreier, Jack Morgenstein, Rony Efraim, netdev,
	kernel-janitors

"work" needs to be freed before returning on this error path.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c
index 707a7d0..299d018 100644
--- a/drivers/net/ethernet/mellanox/mlx4/cmd.c
+++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c
@@ -1572,6 +1572,7 @@ int mlx4_master_immediate_activate_vlan_qos(struct mlx4_priv *priv,
 					   vp_admin->default_vlan,
 					   &admin_vlan_ix);
 		if (err) {
+			kfree(work);
 			mlx4_warn((&priv->dev),
 				  "No vlan resources slave %d, port %d\n",
 				  slave, port);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch -next] net/mlx4: fix small memory leak on error
  2013-07-03  9:37 [patch -next] net/mlx4: fix small memory leak on error Dan Carpenter
@ 2013-07-03 23:52 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-07-03 23:52 UTC (permalink / raw)
  To: dan.carpenter; +Cc: ogerlitz, roland, jackm, ronye, netdev, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 3 Jul 2013 12:37:46 +0300

> "work" needs to be freed before returning on this error path.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-03 23:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-03  9:37 [patch -next] net/mlx4: fix small memory leak on error Dan Carpenter
2013-07-03 23:52 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).