netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, dborkman@redhat.com, ncardwell@google.com
Subject: Re: [PATCH] net: sock: fix TCP_SKB_MIN_TRUESIZE
Date: Wed, 03 Jul 2013 16:52:55 -0700 (PDT)	[thread overview]
Message-ID: <20130703.165255.2199744750245012601.davem@davemloft.net> (raw)
In-Reply-To: <1372852942.4979.67.camel@edumazet-glaptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 03 Jul 2013 05:02:22 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> commit eea86af6b1e18d ("net: sock: adapt SOCK_MIN_RCVBUF and
> SOCK_MIN_SNDBUF") forgot the sk_buff alignment taken into account
> in __alloc_skb() : skb->truesize = SKB_TRUESIZE(size);
> 
> While above commit fixed the sender issue, the receiver is still
> dropping the second packet (on loopback device), because the receiver
> socket can not really hold two skbs :
> First packet truesize already is above sk_rcvbuf, so even TCP coalescing
> cannot help.
> 
> On a typical 64bit build, each tcp skb truesize is 2304, instead of 2272
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied.

      parent reply	other threads:[~2013-07-03 23:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19 10:51 [PATCH net,v2] net: sock: adapt SOCK_MIN_RCVBUF and SOCK_MIN_SNDBUF Daniel Borkmann
2013-06-19 12:19 ` Eric Dumazet
2013-06-20  4:17   ` David Miller
2013-07-03 12:02     ` [PATCH] net: sock: fix TCP_SKB_MIN_TRUESIZE Eric Dumazet
2013-07-03 15:31       ` Neal Cardwell
2013-07-03 23:52       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130703.165255.2199744750245012601.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).