From: David Miller <davem@davemloft.net>
To: ramirose@gmail.com
Cc: netdev@vger.kernel.org, nicolas.dichtel@6wind.com
Subject: Re: [PATCH v2 net-next] ipmr: change the prototype of ip_mr_forward().
Date: Thu, 04 Jul 2013 14:27:24 -0700 (PDT) [thread overview]
Message-ID: <20130704.142724.1657930430240129696.davem@davemloft.net> (raw)
In-Reply-To: <1372976155-2490-1-git-send-email-ramirose@gmail.com>
From: Rami Rosen <ramirose@gmail.com>
Date: Fri, 5 Jul 2013 01:15:55 +0300
> @@ -127,7 +127,7 @@ static struct kmem_cache *mrt_cachep __read_mostly;
> static struct mr_table *ipmr_new_table(struct net *net, u32 id);
> static void ipmr_free_table(struct mr_table *mrt);
>
> -static int ip_mr_forward(struct net *net, struct mr_table *mrt,
> +static void ip_mr_forward(struct net *net, struct mr_table *mrt,
> struct sk_buff *skb, struct mfc_cache *cache,
> int local);
> static int ipmr_cache_report(struct mr_table *mrt,
When you change the column that the openning parenthesis of a function
declaration appears at, you must reindent all of the subsequent lines
of the declaration such that the first character lines up with the first
column after the openning parenthesis.
> @@ -1795,7 +1795,7 @@ static int ipmr_find_vif(struct mr_table *mrt, struct net_device *dev)
>
> /* "local" means that we should preserve one skb (for local delivery) */
>
> -static int ip_mr_forward(struct net *net, struct mr_table *mrt,
> +static void ip_mr_forward(struct net *net, struct mr_table *mrt,
> struct sk_buff *skb, struct mfc_cache *cache,
> int local)
Likewise.
prev parent reply other threads:[~2013-07-04 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 22:15 [PATCH v2 net-next] ipmr: change the prototype of ip_mr_forward() Rami Rosen
2013-07-04 19:49 ` Daniel Borkmann
2013-07-04 21:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130704.142724.1657930430240129696.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).