From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net] sfc: Fix memory leak when discarding scattered packets
Date: Fri, 05 Jul 2013 01:29:58 -0700 (PDT) [thread overview]
Message-ID: <20130705.012958.510964485167451748.davem@davemloft.net> (raw)
In-Reply-To: <1372978126.1853.11.camel@bwh-desktop.uk.level5networks.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 4 Jul 2013 23:48:46 +0100
> Commit 2768935a4660 ('sfc: reuse pages to avoid DMA mapping/unmapping
> costs') did not fully take account of DMA scattering which was
> introduced immediately before. If a received packet is invalid and
> must be discarded, we only drop a reference to the first buffer's
> page, but we need to drop a reference for each buffer the packet
> used.
>
> I think this bug was missed partly because efx_recycle_rx_buffers()
> was not renamed and so no longer does what its name says. It does not
> change the state of buffers, but only prepares the underlying pages
> for recycling. Rename it accordingly.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> This bug fix needs to go into 3.10.y as well.
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2013-07-05 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 22:48 [PATCH net] sfc: Fix memory leak when discarding scattered packets Ben Hutchings
2013-07-05 8:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130705.012958.510964485167451748.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).