From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 0/2] virtio_net: fix race in RX VQ processing Date: Mon, 08 Jul 2013 20:54:52 -0700 (PDT) Message-ID: <20130708.205452.1798118018128812181.davem@davemloft.net> References: <1373274069-4301-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, rusty@rustcorp.com.au, jasowang@redhat.com To: mst@redhat.com Return-path: In-Reply-To: <1373274069-4301-1-git-send-email-mst@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: "Michael S. Tsirkin" Date: Mon, 8 Jul 2013 12:05:26 +0300 > Jason Wang reported a race in RX VQ processing: > virtqueue_enable_cb is called outside napi lock, > violating virtio serialization rules. > The race has been there from day 1, but it got especially nasty in 3.0 > when commit a5c262c5fd83ece01bd649fb08416c501d4c59d7 > "virtio_ring: support event idx feature" > added more dependency on vq state. > > Please review, and consider for 3.11 and for stable. > > Jason, could you please report whether this fixes the issues for you? Please resubmit with the minor coding style fix and Jason's Acked-by/Tested-by Thanks.