* [PATCH 07/12] drivers/net/can/c_can: don't use devm_pinctrl_get_select_default() in probe
[not found] <1373471889-18107-1-git-send-email-wsa@the-dreams.de>
@ 2013-07-10 15:57 ` Wolfram Sang
2013-07-10 21:02 ` Marc Kleine-Budde
2013-07-12 0:18 ` David Miller
2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang
2013-07-10 15:57 ` [PATCH 09/12] drivers/net/ieee802154: " Wolfram Sang
2 siblings, 2 replies; 9+ messages in thread
From: Wolfram Sang @ 2013-07-10 15:57 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Wolfgang Grandegger, Marc Kleine-Budde,
AnilKumar Ch, David S. Miller, Tony Lindgren, Jingoo Han,
linux-can, netdev
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/net/can/c_can/c_can_platform.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c
index b918c73..c6f838d 100644
--- a/drivers/net/can/c_can/c_can_platform.c
+++ b/drivers/net/can/c_can/c_can_platform.c
@@ -32,7 +32,6 @@
#include <linux/clk.h>
#include <linux/of.h>
#include <linux/of_device.h>
-#include <linux/pinctrl/consumer.h>
#include <linux/can/dev.h>
@@ -114,7 +113,6 @@ static int c_can_plat_probe(struct platform_device *pdev)
struct c_can_priv *priv;
const struct of_device_id *match;
const struct platform_device_id *id;
- struct pinctrl *pinctrl;
struct resource *mem, *res;
int irq;
struct clk *clk;
@@ -131,11 +129,6 @@ static int c_can_plat_probe(struct platform_device *pdev)
id = platform_get_device_id(pdev);
}
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl))
- dev_warn(&pdev->dev,
- "failed to configure pins from driver\n");
-
/* get the appropriate clk */
clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(clk)) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 07/12] drivers/net/can/c_can: don't use devm_pinctrl_get_select_default() in probe
2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
@ 2013-07-10 21:02 ` Marc Kleine-Budde
2013-07-10 21:14 ` David Miller
2013-07-12 0:18 ` David Miller
1 sibling, 1 reply; 9+ messages in thread
From: Marc Kleine-Budde @ 2013-07-10 21:02 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Wolfgang Grandegger, AnilKumar Ch, David S. Miller,
Tony Lindgren, Jingoo Han, linux-can, netdev
[-- Attachment #1: Type: text/plain, Size: 720 bytes --]
On 07/10/2013 05:57 PM, Wolfram Sang wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for setting the default pins. Compile tested only.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Who takes care of this patch/patch series?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 07/12] drivers/net/can/c_can: don't use devm_pinctrl_get_select_default() in probe
2013-07-10 21:02 ` Marc Kleine-Budde
@ 2013-07-10 21:14 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2013-07-10 21:14 UTC (permalink / raw)
To: mkl; +Cc: wsa, linux-kernel, wg, anilkumar, tony, jg1.han, linux-can,
netdev
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Wed, 10 Jul 2013 23:02:57 +0200
> On 07/10/2013 05:57 PM, Wolfram Sang wrote:
>> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
>> we can rely on device core for setting the default pins. Compile tested only.
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
>> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Who takes care of this patch/patch series?
Good question :-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 07/12] drivers/net/can/c_can: don't use devm_pinctrl_get_select_default() in probe
2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
2013-07-10 21:02 ` Marc Kleine-Budde
@ 2013-07-12 0:18 ` David Miller
1 sibling, 0 replies; 9+ messages in thread
From: David Miller @ 2013-07-12 0:18 UTC (permalink / raw)
To: wsa; +Cc: linux-kernel, wg, mkl, anilkumar, tony, jg1.han, linux-can,
netdev
From: Wolfram Sang <wsa@the-dreams.de>
Date: Wed, 10 Jul 2013 16:57:42 +0100
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for setting the default pins. Compile tested only.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 08/12] drivers/net/ethernet/cadence: don't use devm_pinctrl_get_select_default() in probe
[not found] <1373471889-18107-1-git-send-email-wsa@the-dreams.de>
2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
@ 2013-07-10 15:57 ` Wolfram Sang
2013-07-11 7:40 ` Nicolas Ferre
2013-07-12 0:19 ` David Miller
2013-07-10 15:57 ` [PATCH 09/12] drivers/net/ieee802154: " Wolfram Sang
2 siblings, 2 replies; 9+ messages in thread
From: Wolfram Sang @ 2013-07-10 15:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Wolfram Sang, Nicolas Ferre, netdev
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/net/ethernet/cadence/at91_ether.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c
index 3f19571..bb5d63f 100644
--- a/drivers/net/ethernet/cadence/at91_ether.c
+++ b/drivers/net/ethernet/cadence/at91_ether.c
@@ -29,7 +29,6 @@
#include <linux/of.h>
#include <linux/of_device.h>
#include <linux/of_net.h>
-#include <linux/pinctrl/consumer.h>
#include "macb.h"
@@ -309,7 +308,6 @@ static int __init at91ether_probe(struct platform_device *pdev)
struct resource *regs;
struct net_device *dev;
struct phy_device *phydev;
- struct pinctrl *pinctrl;
struct macb *lp;
int res;
u32 reg;
@@ -319,15 +317,6 @@ static int __init at91ether_probe(struct platform_device *pdev)
if (!regs)
return -ENOENT;
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl)) {
- res = PTR_ERR(pinctrl);
- if (res == -EPROBE_DEFER)
- return res;
-
- dev_warn(&pdev->dev, "No pinctrl provided\n");
- }
-
dev = alloc_etherdev(sizeof(struct macb));
if (!dev)
return -ENOMEM;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 08/12] drivers/net/ethernet/cadence: don't use devm_pinctrl_get_select_default() in probe
2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang
@ 2013-07-11 7:40 ` Nicolas Ferre
2013-07-12 0:19 ` David Miller
1 sibling, 0 replies; 9+ messages in thread
From: Nicolas Ferre @ 2013-07-11 7:40 UTC (permalink / raw)
To: Wolfram Sang, netdev, David Miller; +Cc: linux-kernel
On 10/07/2013 17:57, Wolfram Sang :
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for setting the default pins. Compile tested only.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks Wolfram.
Bye,
> ---
> drivers/net/ethernet/cadence/at91_ether.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c
> index 3f19571..bb5d63f 100644
> --- a/drivers/net/ethernet/cadence/at91_ether.c
> +++ b/drivers/net/ethernet/cadence/at91_ether.c
> @@ -29,7 +29,6 @@
> #include <linux/of.h>
> #include <linux/of_device.h>
> #include <linux/of_net.h>
> -#include <linux/pinctrl/consumer.h>
>
> #include "macb.h"
>
> @@ -309,7 +308,6 @@ static int __init at91ether_probe(struct platform_device *pdev)
> struct resource *regs;
> struct net_device *dev;
> struct phy_device *phydev;
> - struct pinctrl *pinctrl;
> struct macb *lp;
> int res;
> u32 reg;
> @@ -319,15 +317,6 @@ static int __init at91ether_probe(struct platform_device *pdev)
> if (!regs)
> return -ENOENT;
>
> - pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> - if (IS_ERR(pinctrl)) {
> - res = PTR_ERR(pinctrl);
> - if (res == -EPROBE_DEFER)
> - return res;
> -
> - dev_warn(&pdev->dev, "No pinctrl provided\n");
> - }
> -
> dev = alloc_etherdev(sizeof(struct macb));
> if (!dev)
> return -ENOMEM;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 08/12] drivers/net/ethernet/cadence: don't use devm_pinctrl_get_select_default() in probe
2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang
2013-07-11 7:40 ` Nicolas Ferre
@ 2013-07-12 0:19 ` David Miller
1 sibling, 0 replies; 9+ messages in thread
From: David Miller @ 2013-07-12 0:19 UTC (permalink / raw)
To: wsa; +Cc: linux-kernel, nicolas.ferre, netdev
From: Wolfram Sang <wsa@the-dreams.de>
Date: Wed, 10 Jul 2013 16:57:43 +0100
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for setting the default pins. Compile tested only.
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 09/12] drivers/net/ieee802154: don't use devm_pinctrl_get_select_default() in probe
[not found] <1373471889-18107-1-git-send-email-wsa@the-dreams.de>
2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang
@ 2013-07-10 15:57 ` Wolfram Sang
[not found] ` <1373471889-18107-9-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2 siblings, 1 reply; 9+ messages in thread
From: Wolfram Sang @ 2013-07-10 15:57 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, Alexander Smirnov, Dmitry Eremin-Solenikov,
linux-zigbee-devel, netdev
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/net/ieee802154/mrf24j40.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index ede3ce4..42e6dee 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -22,7 +22,6 @@
#include <linux/spi/spi.h>
#include <linux/interrupt.h>
#include <linux/module.h>
-#include <linux/pinctrl/consumer.h>
#include <net/wpan-phy.h>
#include <net/mac802154.h>
#include <net/ieee802154.h>
@@ -627,7 +626,6 @@ static int mrf24j40_probe(struct spi_device *spi)
int ret = -ENOMEM;
u8 val;
struct mrf24j40 *devrec;
- struct pinctrl *pinctrl;
printk(KERN_INFO "mrf24j40: probe(). IRQ: %d\n", spi->irq);
@@ -638,11 +636,6 @@ static int mrf24j40_probe(struct spi_device *spi)
if (!devrec->buf)
goto err_buf;
- pinctrl = devm_pinctrl_get_select_default(&spi->dev);
- if (IS_ERR(pinctrl))
- dev_warn(&spi->dev,
- "pinctrl pins are not configured from the driver");
-
spi->mode = SPI_MODE_0; /* TODO: Is this appropriate for right here? */
if (spi->max_speed_hz > MAX_SPI_SPEED_HZ)
spi->max_speed_hz = MAX_SPI_SPEED_HZ;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread