From: David Miller <davem@davemloft.net>
To: paolo.valente@unimore.it
Cc: jhs@mojatatu.com, shemminger@vyatta.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, fchecconi@gmail.com,
rizzo@iet.unipi.it, David.Laight@ACULAB.COM
Subject: Re: [PATCH 0/2] pkt_sched: sch_qfq: efficiency and codestyle improvements
Date: Thu, 11 Jul 2013 13:01:32 -0700 (PDT) [thread overview]
Message-ID: <20130711.130132.1487792546552701732.davem@davemloft.net> (raw)
In-Reply-To: <1373463969-11285-1-git-send-email-paolo.valente@unimore.it>
From: Paolo Valente <paolo.valente@unimore.it>
Date: Wed, 10 Jul 2013 15:46:07 +0200
> Hi,
> this patchset tries to address the two issues raised by Dave in
> http://marc.info/?l=linux-kernel&m=136254542019113&w=2
>
> The first of these issues has been also raised by
> David Laight:
> http://marc.info/?l=linux-kernel&m=136256446624557&w=2
>
>> Although two topics for possibly resolving later:
>>
>> 1) That 1ULL bit mask fix is quite expensive on 32-bit, it would
>> probably be cheaper to test for that case using a helper function
>> that nops out on 64-bit. Although this is not so important.
>>
> I have tried to find a simple solution, based on the properties of the mask.
> It is in the first patch.
>
>> 2) That static inline forward declaration is ugly, better to remove
>> the inline tag (let the compiler handle it) or move the function
>> above all the call sites.
>>
> Done by the second patch.
Looks good, thanks for doing this, both applied.
prev parent reply other threads:[~2013-07-11 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 17:31 [PATCH BUGFIX] pkt_sched: fix little service anomalies and possible crashes of qfq+ Paolo valente
2012-12-26 23:13 ` David Miller
2013-02-26 17:02 ` Paolo valente
2013-02-26 22:37 ` David Miller
2013-03-05 18:04 ` [PATCH BUGFIX 0/6] " Paolo valente
2013-03-05 18:04 ` [PATCH BUGFIX 1/6] pkt_sched: properly cap timestamps in charge_actual_service Paolo valente
2013-03-05 18:04 ` [PATCH BUGFIX 2/6] pkt_sched: fix the update of eligible-group sets Paolo valente
2013-03-06 10:05 ` David Laight
2013-03-05 18:04 ` [PATCH BUGFIX 3/6] pkt_sched: serve activated aggregates immediately if the scheduler is empty Paolo valente
2013-03-05 18:05 ` [PATCH BUGFIX 4/6] pkt_sched: prevent budget from wrapping around after a dequeue Paolo valente
2013-03-05 18:05 ` [PATCH BUGFIX 5/6] pkt_sched: do not allow virtual time to jump if an aggregate is in service Paolo valente
2013-03-05 18:05 ` [PATCH BUGFIX 6/6] pkt_sched: remove a useless invocation of qfq_update_eligible Paolo valente
2013-03-06 4:50 ` [PATCH BUGFIX 0/6] pkt_sched: fix little service anomalies and possible crashes of qfq+ David Miller
2013-07-10 13:46 ` [PATCH 0/2] pkt_sched: sch_qfq: efficiency and codestyle improvements Paolo Valente
2013-07-10 13:46 ` [PATCH 1/2] pkt_sched: sch_qfq: improve efficiency of make_eligible Paolo Valente
2013-07-10 13:46 ` [PATCH 2/2] pkt_sched: sch_qfq: remove forward declaration of qfq_update_agg_ts Paolo Valente
2013-07-11 20:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711.130132.1487792546552701732.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=fchecconi@gmail.com \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.valente@unimore.it \
--cc=rizzo@iet.unipi.it \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).