From: David Miller <davem@davemloft.net>
To: john.fastabend@gmail.com
Cc: stephen@networkplumber.org, ben@decadent.org.uk,
jesse.brandeburg@intel.com, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com, therbert@google.com
Subject: Re: [RFC PATCH] net: add a rate_limit attribute to netdev_queue and a rtnetlink
Date: Thu, 11 Jul 2013 16:35:01 -0700 (PDT) [thread overview]
Message-ID: <20130711.163501.353724739279106871.davem@davemloft.net> (raw)
In-Reply-To: <20130710140409.6691.77084.stgit@nitbit.x32>
From: John Fastabend <john.fastabend@gmail.com>
Date: Wed, 10 Jul 2013 07:04:12 -0700
> /* Queue Attributes management
> * Nested layout of queue attributes is:
> * [IFLA_QUEUE_ATTRIBS]
> * [IFLA_QUEUE_ATTRIB]
> * [IFLA_QUEUE_INDEX] <required>
> * [IFLA_QUEUE_RATE] <optional>
> * [IFLA_QUEUE_ATTRIB]
> * [...]
> */
Since these are specifically TX queue attributes, and not
RX queue attributes, please add "_TX_" in the names both
of the attributes themselves and the ->ndo_*() method.
> +static const struct nla_policy ifla_queue_policy[IFLA_QUEUE_MAX+1] = {
> + [IFLA_QUEUE_INDEX] = { .type = NLA_U32},
> + [IFLA_QUEUE_RATE] = { .type = NLA_U32},
> +};
Space needed after NLA_U32 and the closing brace.
prev parent reply other threads:[~2013-07-11 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 14:04 [RFC PATCH] net: add a rate_limit attribute to netdev_queue and a rtnetlink John Fastabend
2013-07-10 21:18 ` Tom Herbert
2013-07-11 3:10 ` John Fastabend
2013-07-14 17:44 ` Jamal Hadi Salim
2013-07-14 21:14 ` Tom Herbert
2013-07-15 3:02 ` John Fastabend
2013-07-11 23:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711.163501.353724739279106871.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).