From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, petrus.lt@gmail.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net RESEND v2] ipv6: fix route selection if kernel is not compiled with CONFIG_IPV6_ROUTER_PREF
Date: Thu, 11 Jul 2013 12:15:34 +0200 [thread overview]
Message-ID: <20130711101534.GA5207@order.stressinduktion.org> (raw)
In-Reply-To: <20130710.173633.631366598766526289.davem@davemloft.net>
On Wed, Jul 10, 2013 at 05:36:33PM -0700, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@stressinduktion.org>
> Date: Wed, 10 Jul 2013 23:00:12 +0200
>
> > I changed the return value of rt6_check_neigh to:
> > 1 in case of the dst entry validated
> > -1 in case of we had no dst_entry and we need to do rr now
> > -2 in case a we had a dst_entry and it did not validate
>
> Please, at the very least, create an enumeration for this set of
> possible return values.
Yes, this should have caught my eyes earlier.
> Although I don't like how that RR boolean is passed around by
> reference, I can't suggest anything better so I won't require
> you to get rid of that.
I fear so, too. I also tought about marking the soft-fail state in the
pointer or adding a rt6_match structure. But both seem more complex to me.
Will send an updated patch shortly.
Thanks,
Hannes
prev parent reply other threads:[~2013-07-11 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 21:00 [PATCH net RESEND v2] ipv6: fix route selection if kernel is not compiled with CONFIG_IPV6_ROUTER_PREF Hannes Frederic Sowa
2013-07-11 0:36 ` David Miller
2013-07-11 10:15 ` Hannes Frederic Sowa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711101534.GA5207@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=petrus.lt@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).