From: David Miller <davem@redhat.com>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, jcliburn@gmail.com, chris.snook@gmail.com
Subject: Re: [net PATCH] atl1e: fix dma mapping warnings
Date: Fri, 12 Jul 2013 16:26:52 -0700 (PDT) [thread overview]
Message-ID: <20130712.162652.1236723636413575644.davem@redhat.com> (raw)
In-Reply-To: <1373641128-13634-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 12 Jul 2013 10:58:48 -0400
> Recently had this backtrace reported:
...
> The usual straighforward failure to check for dma_mapping_error after a map
> operation is completed.
>
> This patch should fix it, the reporter wandered off after filing this bz:
> https://bugzilla.redhat.com/show_bug.cgi?id=954170
>
> and I don't have hardware to test, but the fix is pretty straightforward, so I
> figured I'd post it for review.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied with one style fix:
> -static void atl1e_tx_map(struct atl1e_adapter *adapter,
> +static int atl1e_tx_map(struct atl1e_adapter *adapter,
> struct sk_buff *skb, struct atl1e_tpd_desc *tpd)
I properly reindented the second line of the argument list.
Thanks.
next prev parent reply other threads:[~2013-07-12 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 14:58 [net PATCH] atl1e: fix dma mapping warnings Neil Horman
2013-07-12 16:04 ` Luis Henriques
2013-07-12 16:26 ` Neil Horman
2013-07-12 16:29 ` Neil Horman
2013-07-12 16:38 ` Luis Henriques
2013-07-12 16:53 ` Neil Horman
2013-07-12 23:26 ` David Miller [this message]
2013-07-14 2:22 ` Neil Horman
2013-07-16 0:01 ` Ben Hutchings
2013-07-16 11:12 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130712.162652.1236723636413575644.davem@redhat.com \
--to=davem@redhat.com \
--cc=chris.snook@gmail.com \
--cc=jcliburn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).