netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@redhat.com>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org, nicolas.dichtel@6wind.com
Subject: Re: [PATCH net v3] ipv6: only static routes qualify for equal cost multipathing
Date: Fri, 12 Jul 2013 16:30:53 -0700 (PDT)	[thread overview]
Message-ID: <20130712.163053.1149528998452445963.davem@redhat.com> (raw)
In-Reply-To: <20130712214633.GQ12611@order.stressinduktion.org>

From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 12 Jul 2013 23:46:33 +0200

> Static routes in this case are non-expiring routes which did not get
> configured by autoconf or by icmpv6 redirects.
> 
> To make sure we actually get an ecmp route while searching for the first
> one in this fib6_node's leafs, also make sure it matches the ecmp route
> assumptions.
> 
> v2:
> a) Removed RTF_EXPIRE check in dst.from chain. The check of RTF_ADDRCONF
>    already ensures that this route, even if added again without
>    RTF_EXPIRES (in case of a RA announcement with infinite timeout),
>    does not cause the rt6i_nsiblings logic to go wrong if a later RA
>    updates the expiration time later.
> 
> v3:
> a) Allow RTF_EXPIRES routes to enter the ecmp route set. We have to do so,
>    because an pmtu event could update the RTF_EXPIRES flag and we would
>    not count this route, if another route joins this set. We now filter
>    only for RTF_GATEWAY|RTF_ADDRCONF|RTF_DYNAMIC, which are flags that
>    don't get changed after rt6_info construction.
> 
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

Applied and queued up for -stable, thanks.

      reply	other threads:[~2013-07-12 23:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 21:46 [PATCH net v3] ipv6: only static routes qualify for equal cost multipathing Hannes Frederic Sowa
2013-07-12 23:30 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130712.163053.1149528998452445963.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).