From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Willy Tarreau <w@1wt.eu>
Cc: netdev@vger.kernel.org,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH] net: convert mvneta to build_skb()
Date: Mon, 15 Jul 2013 16:34:08 +0200 [thread overview]
Message-ID: <20130715163408.4064699f@skate> (raw)
In-Reply-To: <20130704173552.GA23370@1wt.eu>
Dear Willy Tarreau,
On Thu, 4 Jul 2013 19:35:52 +0200, Willy Tarreau wrote:
> From 0180a5e651dd771de18bf2c031ecfe7bb4c88d3e Mon Sep 17 00:00:00 2001
> From: Willy Tarreau <w@1wt.eu>
> Date: Sat, 15 Jun 2013 23:25:15 +0200
> Subject: [PATCH] net: convert mvneta to build_skb()
>
> We store the frag_size in the mvneta_port struct. In practice we'd need
> a single bit to know how to free the data, but since we need the size to
> call build_skb() anyway, let's store the full size.
>
> With this patch, I observed a reproducible 2% performance improvement on
> HTTP-based benchmarks.
>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
3.11-rc1 is now out. Do you intend to resend an updated version of your
patches, according to the discussions we had?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-07-15 14:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 17:35 [PATCH] net: convert mvneta to build_skb() Willy Tarreau
2013-07-04 21:31 ` David Miller
2013-07-04 22:12 ` Willy Tarreau
2013-07-05 7:17 ` Thomas Petazzoni
2013-07-05 7:43 ` Willy Tarreau
2013-07-05 7:50 ` Thomas Petazzoni
2013-07-05 8:09 ` Willy Tarreau
2013-07-15 14:34 ` Thomas Petazzoni [this message]
2013-07-15 15:12 ` Willy Tarreau
2013-07-15 15:23 ` Thomas Petazzoni
2013-07-15 15:30 ` Willy Tarreau
2013-07-15 15:35 ` Thomas Petazzoni
2013-07-15 15:52 ` Florian Fainelli
2013-07-15 17:01 ` Willy Tarreau
2013-07-15 19:44 ` Thomas Petazzoni
2013-07-15 23:02 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130715163408.4064699f@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=edumazet@google.com \
--cc=gregory.clement@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).