From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
jcliburn@gmail.com, chris.snook@gmail.com
Subject: Re: [net PATCH] atl1e: unmap partially mapped skb on dma error and free skb
Date: Tue, 16 Jul 2013 12:11:25 -0700 (PDT) [thread overview]
Message-ID: <20130716.121125.1312991211924388920.davem@davemloft.net> (raw)
In-Reply-To: <1373986181-15797-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Tue, 16 Jul 2013 10:49:41 -0400
> Ben Hutchings pointed out that my recent update to atl1e:
>
> commit 352900b583b2852152a1e05ea0e8b579292e731e
> Author: Neil Horman <nhorman@tuxdriver.com>
> Date: Fri Jul 12 10:58:48 2013 -0400
>
> atl1e: fix dma mapping warnings
>
> Was missing a bit of code. Specifically it reset the hardware tx ring to its
> origional state when we hit a dma error, but didn't unmap any exiting mappings
> from the operation. This patch fixes that up. It also remembers to free the
> skb in the event that an error occurs, so we don't leak. Untested, as I don't
> have hardware. I think its pretty straightforward, but please review closely.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied, but please refer to commits in the form "$SHA1ID ("Commit message
header line")", I fixed it up for you this time.
next prev parent reply other threads:[~2013-07-16 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 14:49 [net PATCH] atl1e: unmap partially mapped skb on dma error and free skb Neil Horman
2013-07-16 19:11 ` David Miller [this message]
2013-07-16 20:48 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716.121125.1312991211924388920.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=chris.snook@gmail.com \
--cc=jcliburn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).