From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] vxlan: add necessary locking on device removal Date: Wed, 17 Jul 2013 12:51:42 -0700 (PDT) Message-ID: <20130717.125142.1546753660233139444.davem@davemloft.net> References: <20130710155840.73e8da09@nehalam.linuxnetplumber.net> <20130713101818.0d4fa8e0@nehalam.linuxnetplumber.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: pshelar@nicira.com, netdev@vger.kernel.org To: stephen@networkplumber.org Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:52894 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755540Ab3GQTv5 (ORCPT ); Wed, 17 Jul 2013 15:51:57 -0400 In-Reply-To: <20130713101818.0d4fa8e0@nehalam.linuxnetplumber.net> Sender: netdev-owner@vger.kernel.org List-ID: From: Stephen Hemminger Date: Sat, 13 Jul 2013 10:18:18 -0700 > The socket management is now done in workqueue (outside of RTNL) > and protected by vn->sock_lock. There were two possible bugs, first > the vxlan device was removed from the VNI hash table per socket without > holding lock. And there was a race when device is created and the workqueue > could run after deletion. > > Signed-off-by: Stephen Hemminger Applied.