From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] skbuff: ensure to reset dev in skb_scrub_packet()
Date: Mon, 22 Jul 2013 14:54:45 -0700 (PDT) [thread overview]
Message-ID: <20130722.145445.571586476649309482.davem@davemloft.net> (raw)
In-Reply-To: <1374244891-7030-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Fri, 19 Jul 2013 16:41:31 +0200
> Because this function is used to scrub a packet when it cross netns, we must
> ensure that skb->dev points to the new netns.
>
> This was done by eth_type_trans() in dev_forward_skb(), but it's also needed
> for ip tunnels.
>
> I take the opportunity to move the call of skb_scrub_packet() after
> eth_type_trans(), to be sure that pkt_type is set to PACKET_HOST.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Like others I do not like this change at all.
Every write into the SKB is costly at high packet rates, so writing
the device pointer multiple times unnecessarily can't be done.
The device does get set properly in all cases, the netns change is
not violated, so there is nothing wrong with the current code.
prev parent reply other threads:[~2013-07-22 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 14:41 [PATCH] skbuff: ensure to reset dev in skb_scrub_packet() Nicolas Dichtel
2013-07-19 18:21 ` Pravin Shelar
2013-07-19 20:40 ` Nicolas Dichtel
2013-07-19 21:50 ` Pravin Shelar
2013-07-20 20:26 ` Nicolas Dichtel
2013-07-21 6:08 ` Pravin Shelar
2013-07-22 20:45 ` Nicolas Dichtel
2013-07-22 21:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130722.145445.571586476649309482.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).