From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] bgmac: make bgmac depend on bcm47xx Date: Wed, 24 Jul 2013 12:40:59 -0700 (PDT) Message-ID: <20130724.124059.1161220675165309031.davem@davemloft.net> References: <1374614929-7528-1-git-send-email-hauke@hauke-m.de> <20130724110858.01e033323d739cf6b998e2ea@canb.auug.org.au> <20130724135409.GA2385@tuxdriver.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sfr@canb.auug.org.au, hauke@hauke-m.de, zajec5@gmail.com, netdev@vger.kernel.org, linux-next@vger.kernel.org To: linville@tuxdriver.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:34356 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753205Ab3GXTlE (ORCPT ); Wed, 24 Jul 2013 15:41:04 -0400 In-Reply-To: <20130724135409.GA2385@tuxdriver.com> Sender: netdev-owner@vger.kernel.org List-ID: From: "John W. Linville" Date: Wed, 24 Jul 2013 09:54:12 -0400 > On Wed, Jul 24, 2013 at 11:08:58AM +1000, Stephen Rothwell wrote: >> Hi, >> >> On Tue, 23 Jul 2013 23:28:49 +0200 Hauke Mehrtens wrote: >> > >> > bgmac uses bcm47xx_nvram.h which is only available when BCM47XX was >> > selected. Earlier BCMA_HOST_SOC depended on BCM47XX so this was not >> > build on any other archs, but that changed. We should modify this >> > driver to get access to the nvram or the variables through platform >> > data. >> > >> > This fixes a build problem in linux-next reported by Stephen Rothwell: >> > >> > drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: bcm47xx_nvram.h: No such file or directory >> > #include >> > ^ >> > >> > Signed-off-by: Hauke Mehrtens >> > Reported-by: Stephen Rothwell >> >> This patch really needs to go to John as the patch that exposes the >> breakage is in his tree. > > I'll merge this one -- OK, Dave? No problem.