Re: [PATCH V2 net-next 2/2] pch_gbe: Add MinnowBoard support

[David Miller <davem@davemloft.net>]

From: Darren Hart <dvhart@linux.intel.com>
Date: Mon, 22 Jul 2013 14:41:59 -0700

> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
> index da07907..be513a9 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c
 ...
> @@ -277,4 +286,91 @@ void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw)
>  	pch_gbe_phy_read_reg_miic(hw, PHY_PHYSP_CONTROL, &mii_reg);
>  	mii_reg |= PHYSP_CTRL_ASSERT_CRS_TX;
>  	pch_gbe_phy_write_reg_miic(hw, PHY_PHYSP_CONTROL, mii_reg);
> +
> +	/* Setup a TX clock delay on certain platforms */
> +	if (adapter->pdata && adapter->pdata->phy_tx_clk_delay)
> +		pch_gbe_phy_tx_clk_delay(hw);
> +}
> +
> +/* pch_gbe_phy_tx_clk_delay - Setup TX clock delay via the PHY
> + * @hw:	            Pointer to the HW structure
> + * Returns
> + *	0:		Successful.
> + *	-EINVAL:	Invalid argument.
> + */
> +int pch_gbe_phy_tx_clk_delay(struct pch_gbe_hw *hw)
 ...
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h
> index 03264dc..e3e4bc9 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h
> @@ -33,5 +33,7 @@ void pch_gbe_phy_power_up(struct pch_gbe_hw *hw);
>  void pch_gbe_phy_power_down(struct pch_gbe_hw *hw);
>  void pch_gbe_phy_set_rgmii(struct pch_gbe_hw *hw);
>  void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw);
> +int pch_gbe_phy_tx_clk_delay(struct pch_gbe_hw *hw);
> +int pch_gbe_phy_disable_hibernate(struct pch_gbe_hw *hw);


pch_gbe_phy_tx_clk_delay() is only invoked from pch_gbe_phy.c, where it is also
implemented.

Therefore it should be marked static and the declaration removed from
pch_gbe_phy.h

Thanks.