From: Stephen Hemminger <stephen@networkplumber.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Helmut Grohne <h.grohne@cygnusnetworks.de>,
David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] tuntap: allow changing ethtool speed (v2)
Date: Wed, 24 Jul 2013 17:17:50 -0700 [thread overview]
Message-ID: <20130724171750.112cf0df@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1374709250.1732.40.camel@bwh-desktop.uk.level5networks.com>
On Thu, 25 Jul 2013 00:40:50 +0100
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Wed, 2013-07-24 at 16:11 -0700, Stephen Hemminger wrote:
> > The data reported by the ethtool interface for tun/tap devices is
> > artificial. The default speed is 10Mbit. Virtual interfaces are often
> > faster than this nowadays, so the observed bandwidth may exceed the
> > available bandwidth. This patch allows an administrator to change the
> > available bandwidth as reported by ethtool.
> >
> > Signed-off-by: Helmut Grohne <h.grohne@cygnusnetworks.de>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > ---
> > v2 - allow setting duplex as well, fix patch formatting
>
> It's logically full duplex so this doesn't make sense to me.
>
> > ignore other settings in set
> [...]
>
> No, please never do that in ethtool_ops::set_settings. Setting
> unsupported values is an error.
Almost every hardware driver out there allows mucking with settings
that it doesn't care about (like transceiver and port). Why be picky now?
next prev parent reply other threads:[~2013-07-25 0:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 23:11 [PATCH net-next 1/3] tuntap: allow changing ethtool speed (v2) Stephen Hemminger
2013-07-24 23:13 ` [PATCH net-next 2/3] tuntap: allow overriding ethtool driver info Stephen Hemminger
2013-07-24 23:48 ` Ben Hutchings
2013-07-25 0:16 ` Stephen Hemminger
2013-07-25 21:19 ` Ben Hutchings
2013-07-25 21:32 ` Stephen Hemminger
2013-07-25 21:36 ` Ben Hutchings
2013-07-25 21:56 ` Stephen Hemminger
2013-07-24 23:15 ` [PATCH net-next 3/3] tuntap: allow overriding link statistics Stephen Hemminger
2013-07-24 23:40 ` [PATCH net-next 1/3] tuntap: allow changing ethtool speed (v2) Ben Hutchings
2013-07-25 0:17 ` Stephen Hemminger [this message]
2013-07-25 0:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724171750.112cf0df@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=h.grohne@cygnusnetworks.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).