From: David Miller <davem@davemloft.net>
To: sony.chacko@qlogic.com
Cc: gregkh@linuxfoundation.org, rajesh.borundia@qlogic.com,
shahed.shaikh@qlogic.com, jitendra.kalsaria@qlogic.com,
Linux-Driver@qlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: qlcnic binary sysfs file abuse
Date: Thu, 25 Jul 2013 14:09:33 -0700 (PDT) [thread overview]
Message-ID: <20130725.140933.1460349218585474906.davem@davemloft.net> (raw)
In-Reply-To: <0EA5B226BC5C7B45A71BF612AA8A019E355A3BD4@AVMB1.qlogic.org>
From: Sony Chacko <sony.chacko@qlogic.com>
Date: Thu, 25 Jul 2013 19:37:46 +0000
>> -----Original Message-----
>> From: Greg KH [mailto:gregkh@linuxfoundation.org]
>> Sent: Saturday, July 06, 2013 5:30 PM
>> To: Rajesh Borundia; Shahed Shaikh; Jitendra Kalsaria; Sony Chacko; Dept-Eng
>> Linux Driver
>> Cc: netdev; linux-kernel
>> Subject: qlcnic binary sysfs file abuse
>>
>> I was doing a kernel-wide audit on all of the binary sysfs files, and noticed a
>> metric ton of them in the qlcnic driver.
>>
>> So, any objection to me just deleting these entirely? Or, if they really are
>> needed, can I just move them to debugfs, which is where I think they should
>> have been from the beginning?
>
> Some applications are using these files, please move them to debugfs.
This is quite a mess, and I've complained about all of the crazy
files created by qlcnic in the past.
debugfs is for things that do not create a ABI which the kernel has to
maintain forever.
prev parent reply other threads:[~2013-07-25 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 0:29 qlcnic binary sysfs file abuse Greg KH
2013-07-25 19:37 ` Sony Chacko
2013-07-25 20:08 ` Greg KH
2013-07-25 21:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725.140933.1460349218585474906.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linux-Driver@qlogic.com \
--cc=gregkh@linuxfoundation.org \
--cc=jitendra.kalsaria@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rajesh.borundia@qlogic.com \
--cc=shahed.shaikh@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).