From: David Miller <davem@davemloft.net>
To: claudiu.manoil@freescale.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] gianfar: Fix data structure field comments in gianfar.h
Date: Fri, 26 Jul 2013 15:22:57 -0700 (PDT) [thread overview]
Message-ID: <20130726.152257.1002325488353326528.davem@davemloft.net> (raw)
In-Reply-To: <1374677015-23127-1-git-send-email-claudiu.manoil@freescale.com>
From: Claudiu Manoil <claudiu.manoil@freescale.com>
Date: Wed, 24 Jul 2013 17:43:34 +0300
> Improve clarity of struct member comments for tx_q and and rx_q
> (see cur_tx, dirty_tx, skb_curtx). Fix misleading comments (see
> skb_currx, cur_rx) and remove outdated ones (txcount, txtime).
> Make comments readable (and maintainable) by placing them above
> the individual targeted members.
> Fix checkpatch warnings (see __aligned()) and spacing issues
> in the process.
>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
Please don't undo the usage of kerneldoc comments to describe
structure members.
I'm not applying this patch series, sorry.
prev parent reply other threads:[~2013-07-26 22:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 14:43 [PATCH net-next 1/2] gianfar: Fix data structure field comments in gianfar.h Claudiu Manoil
2013-07-24 14:43 ` [PATCH net-next 2/2] gianfar: Remove unused field grp_id in gfar_priv_grp Claudiu Manoil
2013-07-26 22:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726.152257.1002325488353326528.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.manoil@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).