From: David Miller <davem@davemloft.net>
To: pshelar@nicira.com
Cc: sgruszka@redhat.com, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, netdev@vger.kernel.org, tgraf@suug.ch,
shemminger@vyatta.com, rjones@redhat.com, marcel@holtmann.org,
jlayton@redhat.com
Subject: Re: [PATCH 3.11] genetlink: release cb_lock before requesting additional module
Date: Sat, 27 Jul 2013 22:20:03 -0700 (PDT) [thread overview]
Message-ID: <20130727.222003.1753039618642833143.davem@davemloft.net> (raw)
In-Reply-To: <CALnjE+rcMoFkDPSQbD7VKvv2rYzKKEYcARtBH5y_A+ngrLbAzA@mail.gmail.com>
From: Pravin Shelar <pshelar@nicira.com>
Date: Fri, 26 Jul 2013 10:08:25 -0700
> On Fri, Jul 26, 2013 at 2:00 AM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
>> Requesting external module with cb_lock taken can result in
>> the deadlock like showed below:
...
>> Problem start to happen after adding net-pf-16-proto-16-family-nl80211
>> alias name to cfg80211 module by below commit (though that commit
>> itself is perfectly fine):
>>
>> commit fb4e156886ce6e8309e912d8b370d192330d19d3
>> Author: Marcel Holtmann <marcel@holtmann.org>
>> Date: Sun Apr 28 16:22:06 2013 -0700
>>
>> nl80211: Add generic netlink module alias for cfg80211/nl80211
>>
>> Reported-and-tested-by: Jeff Layton <jlayton@redhat.com>
>> Reported-by: Richard W.M. Jones <rjones@redhat.com>
>> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
...
> This is genl issue and it was introduced by commit def3117493eafd
> (genl: Allow concurrent genl callbacks.).
>
> Reviewed-by: Pravin B Shelar <pshelar@nicira.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-07-28 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130712074911.01b5945a@corrin.poochiereds.net>
2013-07-24 9:59 ` hung task while plugging in cfg80211 Stanislaw Gruszka
[not found] ` <20130724095911.GA1637-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-07-25 14:51 ` Jeff Layton
2013-07-26 9:00 ` [PATCH 3.11] genetlink: release cb_lock before requesting additional module Stanislaw Gruszka
2013-07-26 17:08 ` Pravin Shelar
2013-07-28 5:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130727.222003.1753039618642833143.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jlayton@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=rjones@redhat.com \
--cc=sgruszka@redhat.com \
--cc=shemminger@vyatta.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).