From: David Miller <davem@davemloft.net>
To: sam8641@gmail.com
Cc: mlindner@marvell.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sky2: detect and prevent kernel panic from a possible faulty hardware
Date: Tue, 30 Jul 2013 16:19:06 -0700 (PDT) [thread overview]
Message-ID: <20130730.161906.1898764862564749288.davem@davemloft.net> (raw)
In-Reply-To: <1374957354-10142-1-git-send-email-sam8641@gmail.com>
From: Samuel Williams <sam8641@gmail.com>
Date: Sat, 27 Jul 2013 15:35:54 -0500
> A possible faulty hardware might interrupt with a status of 0xffffffff which
> may kernel panic if sky2 driver tries to handle it. Detecting this problem
> may avoid kernel panic.
>
> Signed-off-by: Samuel Williams <sam8641@gmail.com>
Sure, but then the device is basically just going to stop.
I think this change needs to be more comprehensive, for example it
needs to fully reset the device and try to get it operational again.
next prev parent reply other threads:[~2013-07-30 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-27 20:35 [PATCH] sky2: detect and prevent kernel panic from a possible faulty hardware Samuel Williams
2013-07-30 23:19 ` David Miller [this message]
2013-07-30 23:32 ` Stephen Hemminger
2013-07-31 8:18 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730.161906.1898764862564749288.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sam8641@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).