From: David Miller <davem@davemloft.net>
To: himanshu.madhani@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board temperature.
Date: Tue, 30 Jul 2013 19:27:23 -0700 (PDT) [thread overview]
Message-ID: <20130730.192723.699554467882059430.davem@davemloft.net> (raw)
In-Reply-To: <6a88678cfe46e0e4f639e8f80834dd3e4b46fdd1.1375244889.git.himanshu.madhani@qlogic.com>
From: Himanshu Madhani <himanshu.madhani@qlogic.com>
Date: Tue, 30 Jul 2013 21:54:19 -0400
> From: Himanshu Madhani <himanshu.madhani@qlogic.com>
>
> o Added ethtool statistics to display adapter board
> temperature.
>
> Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
A statistic is a count of events, this is not such a thing.
Furthermore, even if this fit the model of statistical events,
there is no way for the user to know what units the value is
in.
Sorry I'm not applying these patches.
next prev parent reply other threads:[~2013-07-31 2:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 1:54 [PATCH net-next 0/6] qlcnic: Mailbox refactoring and ethtool updates Himanshu Madhani
2013-07-31 1:54 ` [PATCH net-next 1/6] qlcnic: Add ethtool statistics for board temperature Himanshu Madhani
2013-07-31 2:27 ` David Miller [this message]
2013-07-31 18:09 ` Himanshu Madhani
2013-07-31 17:47 ` Stephen Hemminger
2013-07-31 1:54 ` [PATCH net-next 2/6] qlcnic: Return appropriate error code Himanshu Madhani
2013-07-31 1:54 ` [PATCH net-next 3/6] qlcnic: Interrupt based driver firmware mailbox mechanism Himanshu Madhani
2013-07-31 1:54 ` [PATCH net-next 4/6] qlcnic: Replace poll mode mailbox interface with interrupt based mailbox interface Himanshu Madhani
2013-07-31 1:54 ` [PATCH net-next 5/6] qlcnic: Enable mailbox interface in poll mode when interrupts are not available Himanshu Madhani
2013-07-31 1:54 ` [PATCH net-next 6/6] qlcnic: Update version to 5.2.45 Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730.192723.699554467882059430.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=himanshu.madhani@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).