From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] netem: Introduce skb_orphan_partial() helper
Date: Wed, 31 Jul 2013 15:00:20 -0700 (PDT) [thread overview]
Message-ID: <20130731.150020.1079928001574422468.davem@davemloft.net> (raw)
In-Reply-To: <1375232108.10515.47.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 30 Jul 2013 17:55:08 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Commit 547669d483e578 ("tcp: xps: fix reordering issues") added
> unexpected reorders in case netem is used in a MQ setup for high
> performance test bed.
>
> ETH=eth0
> tc qd del dev $ETH root 2>/dev/null
> tc qd add dev $ETH root handle 1: mq
> for i in `seq 1 32`
> do
> tc qd add dev $ETH parent 1:$i netem delay 100ms
> done
>
> As all tcp packets are orphaned by netem, TCP stack believes it can
> set skb->ooo_okay on all packets.
>
> In order to allow producers to send more packets, we want to
> keep sk_wmem_alloc from reaching sk_sndbuf limit.
>
> We can do that by accounting one byte per skb in netem queues,
> so that TCP stack is not fooled too much.
...
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2013-07-31 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 0:55 [PATCH net-next] netem: Introduce skb_orphan_partial() helper Eric Dumazet
2013-07-31 3:21 ` Cong Wang
2013-07-31 3:27 ` Eric Dumazet
2013-07-31 22:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731.150020.1079928001574422468.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).