From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: skb_orphan() changes
Date: Wed, 31 Jul 2013 15:24:58 -0700 (PDT) [thread overview]
Message-ID: <20130731.152458.92056892741307118.davem@davemloft.net> (raw)
In-Reply-To: <1375225875.10515.36.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 30 Jul 2013 16:11:15 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> It is illegal to set skb->sk without corresponding destructor.
>
> Its therefore safe for skb_orphan() to not clear skb->sk if
> skb->destructor is not set.
>
> Also avoid clearing skb->destructor if already NULL.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, but personally I would have considered adding an
else clause checking BUG_ON(skb->sk), or are you not so
confident in your assertion? :-)
next prev parent reply other threads:[~2013-07-31 22:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 23:11 [PATCH net-next] net: skb_orphan() changes Eric Dumazet
2013-07-31 22:24 ` David Miller [this message]
2013-07-31 22:44 ` Eric Dumazet
2013-07-31 23:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731.152458.92056892741307118.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).