From: David Miller <davem@davemloft.net>
To: mugunthanvnm@ti.com
Cc: netdev@vger.kernel.org, linux-omap@vger.kernel.org, balbi@ti.com
Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: Add support for new CPSW IP version
Date: Wed, 31 Jul 2013 16:55:30 -0700 (PDT) [thread overview]
Message-ID: <20130731.165530.1374328962435203697.davem@davemloft.net> (raw)
In-Reply-To: <1375272746-24446-1-git-send-email-mugunthanvnm@ti.com>
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Wed, 31 Jul 2013 17:42:26 +0530
> The new IP version has a minor changes and the offsets are same as the previous
> version, so instead of adding CPSW version number in the driver, make the driver
> to fall through to the latest versions so that the new version of CPSW which has
> the same register offsets will work directly without patching the driver.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
Like others, I really think you should check the version explicitly.
Please respin this patch so that it supports new IP versions in that
way.
Thanks.
prev parent reply other threads:[~2013-07-31 23:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 12:12 [net-next PATCH 1/1] drivers: net: cpsw: Add support for new CPSW IP version Mugunthan V N
2013-07-31 14:49 ` Richard Cochran
2013-07-31 15:28 ` Felipe Balbi
2013-07-31 16:38 ` Richard Cochran
2013-07-31 18:45 ` Felipe Balbi
2013-07-31 19:22 ` Richard Cochran
2013-07-31 19:43 ` Felipe Balbi
2013-07-31 19:45 ` Felipe Balbi
2013-07-31 20:04 ` Richard Cochran
2013-07-31 20:07 ` Felipe Balbi
2013-07-31 20:20 ` Richard Cochran
2013-07-31 20:26 ` Felipe Balbi
2013-07-31 20:34 ` Richard Cochran
2013-07-31 21:11 ` Felipe Balbi
2013-08-01 4:43 ` Richard Cochran
2013-08-01 4:46 ` Richard Cochran
2013-07-31 23:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731.165530.1374328962435203697.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).