From: David Miller <davem@davemloft.net>
To: kda@linux-powerpc.org
Cc: venza@brownhat.org, netdev@vger.kernel.org
Subject: Re: [PATCH] sis900: Fix the tx queue timeout issue
Date: Wed, 31 Jul 2013 17:18:51 -0700 (PDT) [thread overview]
Message-ID: <20130731.171851.260577748566053117.davem@davemloft.net> (raw)
In-Reply-To: <20130731.171738.741214690208351644.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 31 Jul 2013 17:17:38 -0700 (PDT)
> From: Denis Kirjanov <kda@linux-powerpc.org>
> Date: Wed, 31 Jul 2013 18:43:02 +0400
>
>> + printk(KERN_DEBUG "%s: Auto negotiation in progress\n",
>> + net_dev->name);
>
> Please use "pr_debug()"
Or even better "netdev_debug()", that way you don't need the
"%s: " prefix in the string at all.
next prev parent reply other threads:[~2013-08-01 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 14:43 [PATCH] sis900: Fix the tx queue timeout issue Denis Kirjanov
2013-08-01 0:17 ` David Miller
2013-08-01 0:18 ` David Miller [this message]
2013-08-02 12:03 ` Ben Hutchings
2013-08-02 12:13 ` Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731.171851.260577748566053117.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kda@linux-powerpc.org \
--cc=netdev@vger.kernel.org \
--cc=venza@brownhat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).