From: David Miller <davem@davemloft.net>
To: linus.luessing@web.de
Cc: amwang@redhat.com, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux@baker-net.org.uk, stephen@networkplumber.org,
herbert@gondor.apana.org.au
Subject: Re: [PATCHv3] bridge: disable snooping if there is no querier
Date: Wed, 31 Jul 2013 17:40:37 -0700 (PDT) [thread overview]
Message-ID: <20130731.174037.1794753574143053874.davem@davemloft.net> (raw)
In-Reply-To: <1375311980-25575-1-git-send-email-linus.luessing@web.de>
From: Linus Lüssing <linus.luessing@web.de>
Date: Thu, 1 Aug 2013 01:06:20 +0200
> If there is no querier on a link then we won't get periodic reports and
> therefore won't be able to learn about multicast listeners behind ports,
> potentially leading to lost multicast packets, especially for multicast
> listeners that joined before the creation of the bridge.
>
> These lost multicast packets can appear since c5c23260594
> ("bridge: Add multicast_querier toggle and disable queries by default")
> in particular.
>
> With this patch we are flooding multicast packets if our querier is
> disabled and if we didn't detect any other querier.
>
> A grace period of the Maximum Response Delay of the querier is added to
> give multicast responses enough time to arrive and to be learned from
> before disabling the flooding behaviour again.
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Looks good, applied, thanks Linus.
next prev parent reply other threads:[~2013-08-01 0:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 12:57 [PATCH] bridge: disable snooping if there is no querier Linus Lüssing
2013-07-25 13:56 ` [PATCHv2] " Linus Lüssing
2013-07-25 16:01 ` Stephen Hemminger
2013-07-25 19:31 ` Linus Lüssing
2013-07-26 22:19 ` Adam Baker
2013-07-27 15:54 ` Linus Lüssing
2013-07-30 23:10 ` David Miller
2013-07-31 23:06 ` [PATCHv3] " Linus Lüssing
2013-08-01 0:40 ` David Miller [this message]
2013-08-05 8:41 ` Paul Bolle
2013-08-05 22:40 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731.174037.1794753574143053874.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linus.luessing@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@baker-net.org.uk \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).