From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: add a temporary sanity check in skb_orphan()
Date: Thu, 01 Aug 2013 12:49:41 -0700 (PDT) [thread overview]
Message-ID: <20130801.124941.615533263470839691.davem@davemloft.net> (raw)
In-Reply-To: <1375382588.10515.181.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 01 Aug 2013 11:43:08 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> David suggested to add a BUG_ON() to catch if some layer
> sets skb->sk pointer without a corresponding destructor.
>
> As skb can sit in a queue, it's mandatory to make sure the
> socket cannot disappear, and it's usually done by taking a
> reference on the socket, then releasing it from the skb
> destructor.
>
> This patch is a follow-up to commit c34a761231b5
> ("net: skb_orphan() changes") and will be reverted after
> catching all possible offenders if any.
>
> Suggested-by: David Miller <davem@davemloft.net>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2013-08-01 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 18:43 [PATCH net-next] net: add a temporary sanity check in skb_orphan() Eric Dumazet
2013-08-01 19:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801.124941.615533263470839691.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).