From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH V2 3/3] ethernet: Convert mac address uses of 6 to ETH_ALEN Date: Thu, 01 Aug 2013 14:10:16 -0700 (PDT) Message-ID: <20130801.141016.1475274289112004539.davem@davemloft.net> References: <20130801205817.GJ23006@n2100.arm.linux.org.uk> <1375391087.2034.82.camel@joe-AO722> <20130801210618.GK23006@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: joe@perches.com, olof@lixom.net, sammy@sammy.net, grundler@parisc-linux.org, mcuos.com@gmail.com, rajesh.borundia@qlogic.com, netdev@vger.kernel.org, sony.chacko@qlogic.com, linux-kernel@vger.kernel.org, manish.chopra@qlogic.com, pcnet32@frontier.com, ron.mercer@qlogic.com, gallatin@myri.com, linux-driver@qlogic.com, jitendra.kalsaria@qlogic.com, linux-arm-kernel@lists.infradead.org, shahed.shaikh@qlogic.com To: linux@arm.linux.org.uk Return-path: In-Reply-To: <20130801210618.GK23006@n2100.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Russell King - ARM Linux Date: Thu, 1 Aug 2013 22:06:18 +0100 > On Thu, Aug 01, 2013 at 02:04:47PM -0700, Joe Perches wrote: >> On Thu, 2013-08-01 at 21:58 +0100, Russell King - ARM Linux wrote: >> > This seems rather obscure - I mean, it's not obvious to driver authors >> > that should be the case. Would it not be better to make this a little >> > more obvious somehow? Maybe __aligned(2) against mac_addr? Or >> > maybe have a debugging check for it? >> >> That'd be for David Miller (cc'd). >> >> I believe he's argued in the past that any alignment check >> for mac addresses was unnecessary. >> >> For all I know it really might not matter because pasemi >> can successfully dereference a ushort against an odd char >> pointer. >> >> I just noticed it and thought it'd be better moved. > > As can ARM too for years now - either in hardware or via fixup for > kernel code. But probably not a good idea if it's done in a fast path.