From: David Miller <davem@davemloft.net>
To: eliezer.tamir@linux.intel.com
Cc: amwang@redhat.com, netdev@vger.kernel.org
Subject: Re: [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set
Date: Thu, 01 Aug 2013 22:51:47 -0700 (PDT) [thread overview]
Message-ID: <20130801.225147.1055884690165323608.davem@davemloft.net> (raw)
In-Reply-To: <51FB21AB.6090003@linux.intel.com>
From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Date: Fri, 02 Aug 2013 06:04:11 +0300
> On 01/08/2013 23:03, David Miller wrote:
>> From: Cong Wang <amwang@redhat.com>
>> Date: Thu, 01 Aug 2013 16:08:07 +0800
>>
>>> Thinking about it again, what is the point of your commit commit
>>> 89bf1b5a683df497c572c4d3bd3f9c9aa919d773 (net: remove NET_LL_RX_POLL
>>> config menue)? After that commit, CONFIG_NET_LL_RX_POLL is not visible
>>> by user and no other configs select it, also since it defaults to y, it
>>> will be _always_ enabled. If this is really what you want, we can simply
>>> remove all !CONFIG_NET_LL_RX_POLL code.
>>
>> Yes we could do that, it has no dependencies which is the usual reason
>> to have a hidden Kconfig var like this.
>
> I think we still need a config option that depends on net and the
> placeholder code.
> What happens then if someone does not configure networking?
> Won't this break select and poll?
Good point.
next prev parent reply other threads:[~2013-08-02 5:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 3:10 [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set Cong Wang
2013-08-01 3:10 ` [Patch v2 net-next 2/2] net: rename CONFIG_NET_LL_RX_POLL to CONFIG_NET_RX_BUSY_POLL Cong Wang
2013-08-01 22:12 ` David Miller
2013-08-01 6:54 ` [Patch net-next 1/2] net: fix a compile error when CONFIG_NET_LL_RX_POLL is not set Eliezer Tamir
2013-08-01 8:08 ` Cong Wang
2013-08-01 20:03 ` David Miller
2013-08-02 3:04 ` Eliezer Tamir
2013-08-02 5:51 ` David Miller [this message]
2013-08-01 7:18 ` David Miller
2013-08-01 7:29 ` Eliezer Tamir
2013-08-01 22:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801.225147.1055884690165323608.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amwang@redhat.com \
--cc=eliezer.tamir@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).