From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net-next v2 1/8] net: introduce generic union inet_addr Date: Fri, 02 Aug 2013 14:50:41 -0700 (PDT) Message-ID: <20130802.145041.845804796107623114.davem@davemloft.net> References: <1375427674-21735-1-git-send-email-amwang@redhat.com> <1375427674-21735-2-git-send-email-amwang@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, dborkman@redhat.com, joe@perches.com, linux-kernel@vger.kernel.org To: amwang@redhat.com Return-path: In-Reply-To: <1375427674-21735-2-git-send-email-amwang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Cong Wang Date: Fri, 2 Aug 2013 15:14:27 +0800 > From: Cong Wang > > Introduce a generic IP address type, union inet_addr, so that > subsystems don't have to use their own definitions. Because > netpoll already defines union inet_addr, just move it to global. > Some of the helper functions will be used by VXLAN IPv6 code too. > > This patch also reuses the "%pIS" specifier, to make it accept > union inet_addr instead of struct sockaddr. > > Cc: Daniel Borkmann > Cc: Joe Perches > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Cong Wang Changing %pIS to %pIA is pure churn, and of zero value that I can see. Every time I review this patch set I discover some new thing that I'm very disappointed with. You're going to have to stop being so ambitious, and start very small. Maybe one tiny patch at a time if needed.