From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net-next v2 8/8] selinux: use generic union inet_addr Date: Fri, 02 Aug 2013 14:51:46 -0700 (PDT) Message-ID: <20130802.145146.215059840395396296.davem@davemloft.net> References: <1375427674-21735-1-git-send-email-amwang@redhat.com> <1375427674-21735-9-git-send-email-amwang@redhat.com> <4528870.px4VD3WrY3@sifl> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: amwang@redhat.com, netdev@vger.kernel.org, james.l.morris@oracle.com, sds@tycho.nsa.gov, eparis@parisplace.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org To: pmoore@redhat.com Return-path: In-Reply-To: <4528870.px4VD3WrY3@sifl> Sender: linux-security-module-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Paul Moore Date: Fri, 02 Aug 2013 10:34:07 -0400 > On Friday, August 02, 2013 03:14:34 PM Cong Wang wrote: >> From: Cong Wang >> >> selinux has some similar definition like union inet_addr, >> it can re-use the generic union inet_addr too. >> >> Cc: James Morris >> Cc: Stephen Smalley >> Cc: Eric Paris >> Cc: Paul Moore >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-security-module@vger.kernel.org >> Signed-off-by: Cong Wang > > Perhaps I'm confusing this with another patch but I though DaveM said he > wasn't going to merge these patches? I didn't like how he added completely unused bloat to various datastructures because he unconditionally put a port field into there. He removed that problem this time, but there are still a lot of things I don't like about this patch series.