From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com
Subject: Re: [PATCH net] net: mlx5: fix sizeof usage in health_care's reg_handler
Date: Fri, 02 Aug 2013 15:11:32 -0700 (PDT) [thread overview]
Message-ID: <20130802.151132.539136654627638979.davem@davemloft.net> (raw)
In-Reply-To: <1375438577-30933-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Fri, 2 Aug 2013 12:16:17 +0200
> Therefore, I strongly assume sizeof(*health->health) is being meant
> to be passed as an argument. Interestingly, there are actually no
> in-tree users of mlx5_[un]register_health_report_handler(), but some
> debugging modules might want to know the correct size instead.
I want these hooks and infrastructure removed immediately.
If there are no in-tree users there is no reason for them to
exist at all.
Thanks.
next prev parent reply other threads:[~2013-08-02 22:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 10:16 [PATCH net] net: mlx5: fix sizeof usage in health_care's reg_handler Daniel Borkmann
2013-08-02 22:11 ` David Miller [this message]
2013-08-02 22:43 ` Daniel Borkmann
2013-08-03 21:42 ` Or Gerlitz
2013-08-05 6:33 ` Eli Cohen
2013-08-05 6:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802.151132.539136654627638979.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).