From: David Miller <davem@davemloft.net>
To: pmoore@redhat.com
Cc: netdev@vger.kernel.org, linux-security-module@vger.kernel.org,
selinux@tycho.nsa.gov
Subject: Re: [PATCH] netlabel: use domain based selectors when address based selectors are not available
Date: Fri, 02 Aug 2013 16:57:23 -0700 (PDT) [thread overview]
Message-ID: <20130802.165723.552710416990351120.davem@davemloft.net> (raw)
In-Reply-To: <20130802184508.22429.94026.stgit@localhost>
From: Paul Moore <pmoore@redhat.com>
Date: Fri, 02 Aug 2013 14:45:08 -0400
> NetLabel has the ability to selectively assign network security labels
> to outbound traffic based on either the LSM's "domain" (different for
> each LSM), the network destination, or a combination of both. Depending
> on the type of traffic, local or forwarded, and the type of traffic
> selector, domain or address based, different hooks are used to label the
> traffic; the goal being minimal overhead.
>
> Unfortunately, there is a bug such that a system using NetLabel domain
> based traffic selectors does not correctly label outbound local traffic
> that is not assigned to a socket. The issue is that in these cases
> the associated NetLabel hook only looks at the address based selectors
> and not the domain based selectors. This patch corrects this by
> checking both the domain and address based selectors so that the correct
> labeling is applied, regardless of the configuration type.
>
> In order to acomplish this fix, this patch also simplifies some of the
> NetLabel domainhash structures to use a more common outbound traffic
> mapping type: struct netlbl_dommap_def. This simplifies some of the code
> in this patch and paves the way for further simplifications in the
> future.
>
> Signed-off-by: Paul Moore <pmoore@redhat.com>
Applied, thanks Paul.
prev parent reply other threads:[~2013-08-02 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 18:45 [PATCH] netlabel: use domain based selectors when address based selectors are not available Paul Moore
2013-08-02 23:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802.165723.552710416990351120.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmoore@redhat.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).