netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shhuiw@gmail.com
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH] vlan: cleanup the usage of vlan_dev_priv(dev)
Date: Fri, 02 Aug 2013 17:33:11 -0700 (PDT)	[thread overview]
Message-ID: <20130802.173311.1369362183750230796.davem@davemloft.net> (raw)
In-Reply-To: <51FC4D52.7070607@gmail.com>

From: Wang Sheng-Hui <shhuiw@gmail.com>
Date: Sat, 03 Aug 2013 08:22:42 +0800

> This patch cleanup 2 points for the usage of vlan_dev_priv(dev):
> 	* In vlan_dev.c/vlan_dev_hard_header, we should use the var *vlan
> 	* directly
> 	  after grabing the pointer at the beginning with
> 	      *vlan = vlan_dev_priv(dev);
>       when we need to access the fields of *vlan.
> 	* In vlan.c/register_vlan_device, add the var *vlan pointer
> 	      struct vlan_dev_priv *vlan;
> 	  to cleanup the code to access the fields of vlan_dev_priv(new_dev).
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>

This patch doesn't even come close to applying to the net-next tree:

patching file net/8021q/vlan.c
Hunk #1 FAILED at 210.
Hunk #2 succeeded at 260 with fuzz 2.
1 out of 2 hunks FAILED -- saving rejects to file net/8021q/vlan.c.rej
patching file net/8021q/vlan_dev.c
Hunk #1 FAILED at 107.
Hunk #2 FAILED at 133.
2 out of 2 hunks FAILED -- saving rejects to file net/8021q/vlan_dev.c.rej

Please respin your changes and resubmit, thanks.

  reply	other threads:[~2013-08-03  0:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-03  0:22 [PATCH] vlan: cleanup the usage of vlan_dev_priv(dev) Wang Sheng-Hui
2013-08-03  0:33 ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-08-03  8:54 Wang Sheng-Hui
2013-08-03 17:33 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130802.173311.1369362183750230796.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shhuiw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).