From: David Miller <davem@davemloft.net>
To: shhuiw@gmail.com
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH][RESEND] vlan: cleanup the usage of vlan_dev_priv(dev)
Date: Fri, 02 Aug 2013 22:03:10 -0700 (PDT) [thread overview]
Message-ID: <20130802.220310.447316606630944097.davem@davemloft.net> (raw)
In-Reply-To: <51FC6492.9000001@gmail.com>
From: Wang Sheng-Hui <shhuiw@gmail.com>
Date: Sat, 03 Aug 2013 10:01:54 +0800
> This patch cleanup 2 points for the usage of vlan_dev_priv(dev):
> * In vlan_dev.c/vlan_dev_hard_header, we should use the var *vlan
> * directly
> after grabing the pointer at the beginning with
> *vlan = vlan_dev_priv(dev);
> when we need to access the fields of *vlan.
> * In vlan.c/register_vlan_device, add the var *vlan pointer
> struct vlan_dev_priv *vlan;
> to cleanup the code to access the fields of vlan_dev_priv(new_dev).
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
> net/8021q/vlan.c | 12 +++++++-----
> net/8021q/vlan_dev.c | 6 +++---
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
> index 2fb2d88..b9d3d7e 100644
> --- a/net/8021q/vlan.c
> +++ b/net/8021q/vlan.c
> @@ -210,6 +210,7 @@ out_vid_del:
> static int register_vlan_device(struct net_device *real_dev, u16
> vlan_id)
This still doesn't apply, because your email client corrupted
the patch.
prev parent reply other threads:[~2013-08-03 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 2:01 [PATCH][RESEND] vlan: cleanup the usage of vlan_dev_priv(dev) Wang Sheng-Hui
2013-08-03 5:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802.220310.447316606630944097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shhuiw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).