From: Stephen Hemminger <stephen@networkplumber.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH net-next] bridge: fix rcu check warning in multicast port group
Date: Sun, 4 Aug 2013 17:19:38 -0700 [thread overview]
Message-ID: <20130804171938.0d515529@nehalam.linuxnetplumber.net> (raw)
Use of RCU here with out marked pointer and function doesn't match prototype
with sparse.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/net/bridge/br_mdb.c 2013-08-04 11:04:02.530470675 -0700
+++ b/net/bridge/br_mdb.c 2013-08-04 17:06:46.457182483 -0700
@@ -61,7 +61,8 @@ static int br_mdb_fill_info(struct sk_bu
for (i = 0; i < mdb->max; i++) {
struct net_bridge_mdb_entry *mp;
- struct net_bridge_port_group *p, **pp;
+ struct net_bridge_port_group *p;
+ struct net_bridge_port_group __rcu **pp;
struct net_bridge_port *port;
hlist_for_each_entry_rcu(mp, &mdb->mhash[i], hlist[mdb->ver]) {
--- a/net/bridge/br_private.h 2013-08-04 11:04:02.534470627 -0700
+++ b/net/bridge/br_private.h 2013-08-04 17:02:29.972453140 -0700
@@ -466,7 +466,7 @@ extern void br_multicast_free_pg(struct
extern struct net_bridge_port_group *br_multicast_new_port_group(
struct net_bridge_port *port,
struct br_ip *group,
- struct net_bridge_port_group *next,
+ struct net_bridge_port_group __rcu *next,
unsigned char state);
extern void br_mdb_init(void);
extern void br_mdb_uninit(void);
next reply other threads:[~2013-08-05 0:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 0:19 Stephen Hemminger [this message]
2013-08-05 1:42 ` [PATCH net-next] bridge: fix rcu check warning in multicast port group David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130804171938.0d515529@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox