* [PATCH net-next] bridge: fix rcu check warning in multicast port group
@ 2013-08-05 0:19 Stephen Hemminger
2013-08-05 1:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2013-08-05 0:19 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Use of RCU here with out marked pointer and function doesn't match prototype
with sparse.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/net/bridge/br_mdb.c 2013-08-04 11:04:02.530470675 -0700
+++ b/net/bridge/br_mdb.c 2013-08-04 17:06:46.457182483 -0700
@@ -61,7 +61,8 @@ static int br_mdb_fill_info(struct sk_bu
for (i = 0; i < mdb->max; i++) {
struct net_bridge_mdb_entry *mp;
- struct net_bridge_port_group *p, **pp;
+ struct net_bridge_port_group *p;
+ struct net_bridge_port_group __rcu **pp;
struct net_bridge_port *port;
hlist_for_each_entry_rcu(mp, &mdb->mhash[i], hlist[mdb->ver]) {
--- a/net/bridge/br_private.h 2013-08-04 11:04:02.534470627 -0700
+++ b/net/bridge/br_private.h 2013-08-04 17:02:29.972453140 -0700
@@ -466,7 +466,7 @@ extern void br_multicast_free_pg(struct
extern struct net_bridge_port_group *br_multicast_new_port_group(
struct net_bridge_port *port,
struct br_ip *group,
- struct net_bridge_port_group *next,
+ struct net_bridge_port_group __rcu *next,
unsigned char state);
extern void br_mdb_init(void);
extern void br_mdb_uninit(void);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] bridge: fix rcu check warning in multicast port group
2013-08-05 0:19 [PATCH net-next] bridge: fix rcu check warning in multicast port group Stephen Hemminger
@ 2013-08-05 1:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-08-05 1:42 UTC (permalink / raw)
To: stephen; +Cc: netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Sun, 4 Aug 2013 17:19:38 -0700
> Use of RCU here with out marked pointer and function doesn't match prototype
> with sparse.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-05 1:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-05 0:19 [PATCH net-next] bridge: fix rcu check warning in multicast port group Stephen Hemminger
2013-08-05 1:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox