From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: andi@firstfloor.org, netdev@vger.kernel.org, ak@linux.intel.com
Subject: Re: [PATCH] lto, wan/sbni: Make inline assembler symbols visible and assembler global
Date: Tue, 6 Aug 2013 01:05:35 +0200 [thread overview]
Message-ID: <20130805230535.GP19750@two.firstfloor.org> (raw)
In-Reply-To: <20130805.153323.276242626385124232.davem@davemloft.net>
On Mon, Aug 05, 2013 at 03:33:23PM -0700, David Miller wrote:
> From: Andi Kleen <andi@firstfloor.org>
> Date: Mon, 5 Aug 2013 15:18:14 -0700
>
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > - Inline assembler defining C callable code has to be global
> > - The function has to be visible
> >
> > Do this in wan/sbni
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Please just make it use the standard lib/ CRC routines instead.
The problem is I don't have this hardware, and I don't think
I can do such a change without testing it.
FWIW my main interest here is to avoid this thing breaking
my allyesconfig build.
Could you please consider adding it?
If not I'll have to disable the driver in the LTO patchkit.
-Andi
next prev parent reply other threads:[~2013-08-05 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 22:18 [PATCH] lto, wan/sbni: Make inline assembler symbols visible and assembler global Andi Kleen
2013-08-05 22:33 ` David Miller
2013-08-05 23:05 ` Andi Kleen [this message]
2013-08-05 23:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805230535.GP19750@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).