netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Rui Xiang <rui.xiang@huawei.com>
Cc: containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org, serge.hallyn@ubuntu.com,
	ebiederm@xmission.com, akpm@linux-foundation.org,
	gaofeng@cn.fujitsu.com, guz.fnst@cn.fujitsu.com,
	libo.chen@huawei.com
Subject: Re: [PATCH v3 11/11] netfilter: use ns_printk in iptable context
Date: Wed, 7 Aug 2013 11:17:22 +0200	[thread overview]
Message-ID: <20130807091722.GA9470@localhost> (raw)
In-Reply-To: <1375861035-24320-12-git-send-email-rui.xiang@huawei.com>

Hi,

On Wed, Aug 07, 2013 at 03:37:15PM +0800, Rui Xiang wrote:
> To containerise iptables log, use ns_printk
> to report individual logs to container as
> getting syslog_ns from net->user_ns.

This patch is missing the removal of a couple of LOC at the very
beginning of ipt_log_packet and ip6t_log_packet to get this working.

Please, revamp it. Thanks.

  reply	other threads:[~2013-08-07  9:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07  7:37 [PATCH v3 00/11] Add namespace support for syslog Rui Xiang
     [not found] ` <1375861035-24320-1-git-send-email-rui.xiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-07  7:37   ` [PATCH v3 01/11] syslog_ns: add syslog_namespace and put/get_syslog_ns Rui Xiang
2013-08-07  7:37   ` [PATCH v3 02/11] syslog_ns: add syslog_ns into user_namespace Rui Xiang
2013-08-07  7:37   ` [PATCH v3 03/11] syslog_ns: add init syslog_ns for global syslog Rui Xiang
2013-08-07  7:37   ` [PATCH v3 06/11] syslog_ns: use init syslog_ns for console action Rui Xiang
2013-08-07  7:37   ` [PATCH v3 07/11] syslog_ns: implement function for creating syslog ns Rui Xiang
     [not found]     ` <1375861035-24320-8-git-send-email-rui.xiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-07 18:59       ` Ben Hutchings
2013-08-07  7:37   ` [PATCH v3 11/11] netfilter: use ns_printk in iptable context Rui Xiang
2013-08-07  9:17     ` Pablo Neira Ayuso [this message]
2013-08-07  7:55   ` [PATCH v3 00/11] Add namespace support for syslog Eric W. Biederman
2013-08-07 13:48     ` Serge Hallyn
     [not found]     ` <878v0evssv.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-08-08  1:37       ` Gao feng
     [not found]         ` <5202F65F.40002-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2013-08-08 11:13           ` Rui Xiang
     [not found]             ` <52037D50.2050109-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-14 15:30               ` Serge E. Hallyn
     [not found]                 ` <20130814153017.GA18403-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2013-08-14 19:21                   ` Eric W. Biederman
     [not found]                     ` <87a9kkcc38.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-08-17 13:38                       ` Serge E. Hallyn
2013-08-07  7:37 ` [PATCH v3 04/11] syslog_ns: make syslog handling per namespace Rui Xiang
     [not found]   ` <1375861035-24320-5-git-send-email-rui.xiang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-08-07 18:52     ` Ben Hutchings
2013-08-07  7:37 ` [PATCH v3 05/11] syslog_ns: make permisiion check per user namespace Rui Xiang
2013-08-07 18:41   ` Ben Hutchings
2013-08-07  7:37 ` [PATCH v3 08/11] syslog_ns: implement ns_printk for specific syslog_ns Rui Xiang
2013-08-07  7:37 ` [PATCH v3 09/11] syslog_ns: implement ns_printk_emit " Rui Xiang
2013-08-07  7:37 ` [PATCH v3 10/11] syslog_ns: implement ns_console_unlock " Rui Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130807091722.GA9470@localhost \
    --to=pablo@netfilter.org \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=gaofeng@cn.fujitsu.com \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=libo.chen@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=rui.xiang@huawei.com \
    --cc=serge.hallyn@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).